Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon should be unknown when no tests are run #4710

Merged
merged 3 commits into from
Mar 13, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Mar 11, 2019

For #4583 #4727 Fixing validation

@karrtikr karrtikr added the no-changelog No news entry required label Mar 11, 2019
@DonJayamanne DonJayamanne self-assigned this Mar 11, 2019
@karrtikr karrtikr closed this Mar 11, 2019
@karrtikr karrtikr reopened this Mar 11, 2019
@codecov
Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #4710 into master will decrease coverage by 1%.
The diff coverage is 93%.

@@           Coverage Diff           @@
##           master   #4710    +/-   ##
=======================================
- Coverage      77%     77%   -<1%     
=======================================
  Files         447     447            
  Lines       21472   21484    +12     
  Branches     3527    3532     +5     
=======================================
+ Hits        16444   16453     +9     
- Misses       5024    5027     +3     
  Partials        4       4
Flag Coverage Δ
#Linux 66% <93%> (+1%) ⬆️
#Windows 66% <93%> (+1%) ⬆️
#macOS 66% <93%> (ø) ⬇️

@karrtikr karrtikr closed this Mar 12, 2019
@karrtikr karrtikr reopened this Mar 12, 2019
@karrtikr karrtikr closed this Mar 12, 2019
@karrtikr karrtikr reopened this Mar 12, 2019
@karrtikr karrtikr closed this Mar 13, 2019
@karrtikr karrtikr reopened this Mar 13, 2019
@DonJayamanne DonJayamanne merged commit 1cc6f39 into microsoft:master Mar 13, 2019
@karrtikr karrtikr deleted the validationIssue branch March 13, 2019 16:33
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants